fix: allow nullable uid in InetOrgPerson#19373
Open
ezhilnn wants to merge 1 commit into
Open
Conversation
Signed-off-by: ezhilnn <ezhilnaga4732@gmail.com>
3c516d5 to
dd57915
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19370
Problem
uidis marked@Nullableon the field but two places contradictedthis:
getUid()calledObjects.requireNonNull(), throwing NPE if uid is nullEssence(DirContextOperations)constructor calledAssert.notNull(),throwing IllegalArgumentException if uid is absent from LDAP context
According to the LDAP inetOrgPerson schema,
uidis not a mandatoryfield. This behavior also regressed from pre-7.1.0 behavior (introduced
in commit c5632cc).
Changes
getUid()now returns@Nullable Stringand returns the field directlysetUid()if absentsetUid()now accepts@Nullable Stringand guards username mappingwith a null check
Testing
testNullUidIsAllowed()to verify null uid no longer throws