Upgrade marino to v0.3.0 - #4576
Merged
Merged
Conversation
JSON_TABLE in schema files, expression DEFAULTs like (UTC_TIMESTAMP()) and (CURRENT_TIMESTAMP + INTERVAL 30 DAY), and trigger/function/ procedure/event DDL in MySQL schemas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
github.com/sqlc-dev/marinofrom v0.2.0 to v0.3.0, picking up the clause-level MySQL 26.7 syntax sweep, and adds endtoend coverage for the newly supported syntax:mysql_json_table—JSON_TABLEin schema filesmysql_default_expression— expression defaults likeDEFAULT (UTC_TIMESTAMP())andDEFAULT (CURRENT_TIMESTAMP + INTERVAL 30 DAY)mysql_ddl_routines—CREATE TRIGGER/CREATE FUNCTION/CREATE PROCEDURE/CREATE EVENTin MySQL schemasAll schema statements in the new cases were verified against a live MySQL 9 server, and the cases pass in both the
baseandmanaged-dbreplay contexts. The fullgo test --tags=examples ./...suite passes with live PostgreSQL and MySQL.Each of the following issues has a verified-working repro on this branch:
Fixed #3129
Fixed #4178
Fixed #4105
Fixed #1403
Fixed #3468
Fixed #2789
Fixed #3977
Fixed #3868
Fixed #3741
Still not fixed by this upgrade (checked):
JSON_ARRAYAGG(DISTINCT …)(#3676, still a marino parse error),TRIM(LEADING … FROM …)(#3405, parses now but fails catalog lookup),RLIKEparameter inference (#3673),LOCK TABLESas a named query (#1643), and MariaDB collationutf8mb4_uca1400_ai_ci(#4222).JSON_TABLEin query files parses but dolphin's converter doesn't yet expose its columns.🤖 Generated with Claude Code
https://claude.ai/code/session_013aeoDHAe87yVsDuDCLPQNc