Skip to content

fix: Re-add rbac permissions required by SDP#397

Merged
adwk67 merged 3 commits into
mainfrom
fix/rbac-openshift
Jun 29, 2026
Merged

fix: Re-add rbac permissions required by SDP#397
adwk67 merged 3 commits into
mainfrom
fix/rbac-openshift

Conversation

@adwk67

@adwk67 adwk67 commented Jun 29, 2026 •
edited by NickLarsenNZ
Loading

Copy link
Copy Markdown
Member

Description

Restore permissions required for openshift, but desired on vanilla Kubernetes.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@NickLarsenNZ NickLarsenNZ self-requested a review June 29, 2026 13:31
@NickLarsenNZ NickLarsenNZ added scheduled-for/26.7.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 29, 2026
@NickLarsenNZ

This comment was marked as duplicate.

Sign in to view
NickLarsenNZ
NickLarsenNZ reviewed Jun 29, 2026
View reviewed changes
Comment thread deploy/helm/listener-operator/templates/roles.yaml Outdated
NickLarsenNZ
NickLarsenNZ previously approved these changes Jun 29, 2026
View reviewed changes

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I think we should remove the comment about "needed by OpenShift".

@adwk67 @NickLarsenNZ
Update deploy/helm/listener-operator/templates/roles.yaml
873d2b1 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
NickLarsenNZ
NickLarsenNZ approved these changes Jun 29, 2026
View reviewed changes

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickLarsenNZ NickLarsenNZ changed the title fix: Re-add rbac permissions required by SDP on openshift fix: Re-add rbac permissions required by SDP Jun 29, 2026
@adwk67 adwk67 added this pull request to the merge queue Jun 29, 2026
Merged via the queue into main with commit e044036 Jun 29, 2026
12 checks passed
@adwk67 adwk67 deleted the fix/rbac-openshift branch June 29, 2026 14:15
@adwk67 adwk67 mentioned this pull request Jun 29, 2026
Open
20 tasks
@NickLarsenNZ NickLarsenNZ added release/26.7.0 and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. scheduled-for/26.7.0 labels Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@adwk67 adwk67

Labels

release/26.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adwk67 @NickLarsenNZ