Remove njump Nostr embeds#2971
Open
nexicturbo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2813.
This removes the njump-backed Nostr embed path and switches outbound Nostr viewer links to damus.io. Specifically:
QA
npm test -- lib/url.spec.js --runInBandnpm run lint -- components/embed.js components/footer.js components/item-info.js components/notifications.js components/user-header.js lib/lexical/mdast/visitors/nostr.js lib/url.js lib/url.spec.js pages/settings/index.js proxy.jsgit diff --checkChecklist
Are your changes backward compatible? Please answer below:
Mostly yes. Existing Nostr IDs still become outbound links, but njump embeds intentionally stop rendering per the issue.
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
No visual runtime QA; this removes a broken iframe embed path and changes outbound link targets.
Did you introduce any new environment variables? If so, call them out explicitly here:
No.
Did you use AI for this? If so, how much did it assist you?
Yes. AI assisted with locating the njump touchpoints, making the focused patch, and running verification. I reviewed the resulting diff before submission.