Skip to content

Fix/tests and defaults - #26

Merged
PaulicStudios merged 4 commits into
mainfrom
fix/tests-and-defaults
Aug 11, 2026
Merged

Fix/tests and defaults#26
PaulicStudios merged 4 commits into
mainfrom
fix/tests-and-defaults

Conversation

@PaulicStudios

@PaulicStudios PaulicStudios commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR contains multiple changes:

  • http.default is not being used anymore when not specifying an http client as it leads to race conditions
  • modified default values for pulling and pulljobs
  • added check for interval not being too short
  • aligned the longpulljob integer to the already existing parameters

@PaulicStudios PaulicStudios self-assigned this Aug 11, 2026
@PaulicStudios
PaulicStudios force-pushed the fix/tests-and-defaults branch from a505625 to 7984710 Compare August 11, 2026 14:06
selinafehn
selinafehn reviewed Aug 11, 2026
View reviewed changes
Comment thread pkg/pubsub/pulljob.go Outdated
Comment thread pkg/pubsub/pulljob.go Outdated
@selinafehn selinafehn closed this Aug 11, 2026
@selinafehn selinafehn reopened this Aug 11, 2026
@PaulicStudios
PaulicStudios merged commit ed55ad5 into main Aug 11, 2026
4 checks passed
@PaulicStudios
PaulicStudios deleted the fix/tests-and-defaults branch August 11, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@selinafehn selinafehn selinafehn approved these changes
@ksussbauer ksussbauer Awaiting requested review from ksussbauer ksussbauer is a code owner
@Scarjit Scarjit Awaiting requested review from Scarjit Scarjit is a code owner

Assignees

@PaulicStudios PaulicStudios

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PaulicStudios @selinafehn