Skip to content

feat: Add kms key options to secrets manager instance commands#1347

Draft
s-inter wants to merge 10 commits intomainfrom
feat/STACKITCLI-338-Add-kms-key-options-to-secrets-manager-instance-commands
Draft

feat: Add kms key options to secrets manager instance commands#1347
s-inter wants to merge 10 commits intomainfrom
feat/STACKITCLI-338-Add-kms-key-options-to-secrets-manager-instance-commands

Conversation

@s-inter
Copy link
Contributor

@s-inter s-inter commented Mar 24, 2026

Description

relates to STACKITCLI-338

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@s-inter s-inter changed the title Feat/STACKITCLI 338 Add kms key options to secrets manager instance commands feat: Add kms key options to secrets manager instance commands Mar 24, 2026
@rubenhoenle
Copy link
Member

please fix the pipeline :)

@rubenhoenle
Copy link
Member

What about the additional output of the describe command?

instanceNameFlag = "name"
aclFlag = "acl"

kmsKeyIdFlag = "kms-key-id"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also adjust the tests of the create command 😅

@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/create 57.38% (+6.43%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/describe 66.67% (+3.51%) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/update 57.14% (+8.36%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/create/create.go 57.38% (+6.43%) 61 (+8) 35 (+8) 26 👍
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/describe/describe.go 66.67% (+3.51%) 69 (+12) 46 (+10) 23 (+2) 👍
github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/update/update.go 57.14% (+8.36%) 56 (+15) 32 (+12) 24 (+3) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/secrets-manager/instance/update/update_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants