Display recorded trust state to the user - #6137
Draft
samuv wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## skills-sig/13-upgrade-guard #6137 +/- ##
===============================================================
+ Coverage 72.53% 72.57% +0.03%
===============================================================
Files 736 736
Lines 76624 76641 +17
===============================================================
+ Hits 55582 55620 +38
+ Misses 17068 17050 -18
+ Partials 3974 3971 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5 tasks
samuv
force-pushed
the
skills-sig/13b-provenance-display
branch
from
August 3, 2026 08:28
baa3b8a to
7359ebd
Compare
samuv
force-pushed
the
skills-sig/13b-provenance-display
branch
from
August 3, 2026 09:07
7359ebd to
a1ed13c
Compare
samuv
force-pushed
the
skills-sig/13b-provenance-display
branch
from
August 3, 2026 13:41
a1ed13c to
e5e22bf
Compare
samuv
force-pushed
the
skills-sig/13b-provenance-display
branch
from
August 3, 2026 14:11
e5e22bf to
683b7df
Compare
samuv
force-pushed
the
skills-sig/13b-provenance-display
branch
from
August 3, 2026 14:47
683b7df to
52ed04e
Compare
samuv
force-pushed
the
skills-sig/13b-provenance-display
branch
from
August 3, 2026 15:15
52ed04e to
d14b72f
Compare
samuv
force-pushed
the
skills-sig/13b-provenance-display
branch
from
August 3, 2026 15:16
d14b72f to
6a65d43
Compare
samuv
force-pushed
the
skills-sig/13b-provenance-display
branch
from
August 4, 2026 08:34
6a65d43 to
15cea4b
Compare
RFC THV-0080 wants the identity pinned at trust-on-first-use displayed prominently, not discovered weeks later inside a signer-mismatch error. ProvenanceInfo becomes part of API responses: install results carry the provenance or unsigned exception that was just recorded (the CLI prints it — a deliberate exception to silent success, since a recorded trust anchor is security-relevant information, not progress chatter), and skill info surfaces the lock file's recorded trust state for project-scoped skills, provisional markers included. Part of #5899. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
samuv
force-pushed
the
skills-sig/13b-provenance-display
branch
from
August 4, 2026 08:35
15cea4b to
c6569e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stack 2 of RFC THV-0080 (tracking issue #5899) — part of stack #6128, on top of #6132. This is the display follow-up promised in #6129's review.
Summary
RFC THV-0080 requires the identity pinned at trust-on-first-use to be "displayed prominently" — today the user first meets it weeks later inside a
signer-mismatch403. This PR surfaces the recorded trust state everywhere it's decided or queried:ProvenanceInfobecomes API-visible (signer_identity,cert_issuer,repository_uri,sigstore_url,provisional) instead ofjson:"-"end to end.provenanceorunsigned, and the CLI prints it —Installed <name> (signed by <identity>), the provisional variant, or the explicit-unsigned variant.thv skill infoshows the lock file's recorded trust state for project-scoped, lock-managed skills (Signed by:/Cert issuer:/ unsigned-exception lines, JSON included).Type of change
Test plan
task lint-fix, 0 issues)installAndRegisternow surfaces it on the result);task docsregenerated (swagger for the new response fields).Does this introduce a user-facing change?
Yes, behind the experimental gate: successful project-scoped installs print the recorded trust state, and
thv skill infoshows the pinned signer identity.Special notes for reviewers
.claude/rules/cli-commands.md): a freshly pinned trust anchor is security-relevant information the RFC requires to be visible, not progress chatter. Happy to gate it differently if you disagree.Generated with Claude Code