[6.x] Add explicit package param to installed tag#14858
Merged
Conversation
jasonvarga
requested changes
Jun 22, 2026
jasonvarga
left a comment
Member
There was a problem hiding this comment.
index() passes null into Composer::isInstalled(string $package) when package is missing/empty, throwing a TypeError and crashing the render (previously {{ installed }} just returned empty). Easy to hit via {{ installed :package="var" }} when var is unset. Can you guard it?
public function index()
{
if (! $package = $this->params->get('package')) {
return;
}
return $this->installed($package);
}
Contributor
Author
|
@jasonvarga Right, good catch! I've pushed your proposed change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow using the
installedtag with a param. Currently, only wildcard usage is supported.{{ package_name = "scope/package" }} {{ installed :package="package_name" }}yes{{ /installed }}