[6.x] Use standard console output helpers in commands - #15092
Merged
Conversation
replaces the custom checkInfo/crossLine helpers with $this->components->info()/error()/warn(), matching the style already used elsewhere. also switches the license key prompt in `ProEnable` to Laravel Prompts' `text()`.
…ands no longer used now that commands use \$this->components for output.
The call sites have moved to the standard console output components, but these are public methods on a public trait that addons may use for their own commands, so removing them in a minor would break them. Deprecated instead, for removal in the next major. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jasonvarga
changed the title
Member
These are public methods so addons might be using them. I've brought them back and deprecated them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces the custom
checkInfo/crossLine/checkLinehelper methods onEnhancesCommandswith the standard$this->components->info()/error()/warn()output, matching the convention already used elsewhere (e.g.Multisite,MakeUser).This PR also switches the license key prompt in
ProEnableover to Laravel Prompts'text(), consistent with other interactive commands.It also updates a couple of other commands.