[6.x] Respect the listing sort order when exporting form submissions - #15105
Open
aerni wants to merge 3 commits into
Open
[6.x] Respect the listing sort order when exporting form submissions#15105aerni wants to merge 3 commits into
aerni wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Form submission exports ignored the listing's sort order.
The sort was only sent when you picked Filtered Submissions, and that option is disabled unless a search or filter is active. And the default date sort didn't count. So the common case, open a form and hit export, always gave you an arbitrarily ordered file.
Behavior changes
Also
The Filtered Submissions description claimed exports respect the visible columns. They don't, so I dropped that half of the sentence.