[core] Add max iteration count for detecting infinite loops#5430
Merged
davidkpiano merged 9 commits intomainfrom Apr 20, 2026
Merged
[core] Add max iteration count for detecting infinite loops#5430davidkpiano merged 9 commits intomainfrom
davidkpiano merged 9 commits intomainfrom
Conversation
- Introduced `MachineOptions` interface to define runtime options, including `maxIterations`. - Updated `StateMachine` class to accept and initialize options from the configuration. - Modified `macrostep` function to utilize the `maxIterations` option, allowing for dynamic iteration limits.
🦋 Changeset detectedLatest commit: 385d3f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Changed default value of `maxIterations` in `MachineOptions` to `Infinity` for no limit. - Enhanced `macrostep` function to support dynamic iteration limits, throwing an error for infinite loops only when a valid limit is set. - Updated tests to reflect new `maxIterations` behavior.
Andarist
reviewed
Jan 7, 2026
Andarist
reviewed
Jan 7, 2026
Andarist
reviewed
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
maxIterationsoption to configure the maximum number of microsteps allowed before throwing an infinite loop error. The default isInfinity(no limit) to avoid breaking existing machines.You can configure it when creating a machine: