Skip to content

feat(core): align repo star field naming and add type coverage - #429

Merged
martin-mfg merged 2 commits into
stats-organization:masterfrom
marcalexiei:core-ts
Aug 1, 2026
Merged

feat(core): align repo star field naming and add type coverage#429
martin-mfg merged 2 commits into
stats-organization:masterfrom
marcalexiei:core-ts

Conversation

@marcalexiei

Copy link
Copy Markdown

Followup of #426 (comment)

Now that we have RepoInfo, would it make sense to define RepositoryData as combination of RepoInfo and RepoUserStats (and align the naming of "starCount"/"stargazerCount") in a later PR?

@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown

@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel.

A member of the Team first needs to authorize it.

@martin-mfg martin-mfg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think until now the object returned by fetchRepo had both starCount and stargazerCount, with the same value. This leads to some redundancies:

Comment thread packages/core/src/fetchers/repo.ts Outdated
Comment thread packages/core/src/fetchers/types.ts Outdated
@marcalexiei
marcalexiei requested a review from martin-mfg August 1, 2026 18:29
@martin-mfg
martin-mfg merged commit 372eaaf into stats-organization:master Aug 1, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants