Skip to content

chore: update example and add missing space in stats/base/dists/normal/mean#12104

Merged
kgryte merged 1 commit into
developfrom
claude/vibrant-brahmagupta-rHlIm
May 13, 2026
Merged

chore: update example and add missing space in stats/base/dists/normal/mean#12104
kgryte merged 1 commit into
developfrom
claude/vibrant-brahmagupta-rHlIm

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter commented May 13, 2026

Description

What is the purpose of this pull request?

This pull request:

  • fixes the C example to use a positive sigma lower bound (0.0 -> 0.1) to avoid producing NaN output and to match the README's C API documentation
  • fixes a missing space before ) in test/test.native.js (!== null) -> !== null ))

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Research and understanding

Disclosure

This PR was written primarily by Claude Code.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label May 13, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 13, 2026

Coverage Report

No coverage information available.

@Planeshifter Planeshifter force-pushed the claude/vibrant-brahmagupta-rHlIm branch from 8d57d0c to d1b7e87 Compare May 13, 2026 01:19
- Fix C example to use positive sigma lower bound (`0.0` -> `0.1`) to
  avoid producing NaN output and match README documentation
- Fix missing space before `)` in `test.native.js` conditional

Closes: https://github.com/stdlib-js/todo/issues/2769

https://claude.ai/code/session_01AdYT9cpbh7ts7S4HGxisz7
@Planeshifter Planeshifter force-pushed the claude/vibrant-brahmagupta-rHlIm branch from d1b7e87 to 363688f Compare May 13, 2026 04:12
@Planeshifter Planeshifter changed the title feat: add C implementation for stats/base/dists/normal/mean fix: address issues in C implementation for stats/base/dists/normal/mean May 13, 2026
@Planeshifter Planeshifter changed the title fix: address issues in C implementation for stats/base/dists/normal/mean chore: address issues in C implementation for stats/base/dists/normal/mean May 13, 2026
@Planeshifter Planeshifter marked this pull request as ready for review May 13, 2026 04:28
@Planeshifter Planeshifter requested review from a team and kgryte May 13, 2026 04:28
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label May 13, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label May 13, 2026
@kgryte kgryte changed the title chore: address issues in C implementation for stats/base/dists/normal/mean chore: update example and add missing space in stats/base/dists/normal/mean May 13, 2026
@kgryte kgryte merged commit bac6704 into develop May 13, 2026
47 checks passed
@kgryte kgryte deleted the claude/vibrant-brahmagupta-rHlIm branch May 13, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants