Skip to content

chore: fix JavaScript lint errors #13619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 2 commits into from
Jul 24, 2026
+4 −2
Merged

chore: fix JavaScript lint errors #13619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6efa0f
chore: fix JavaScript lint errors
Ashutosh-1304 Jul 23, 2026
03ff0d6
refactor: use array utils
kgryte Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/node_modules/@stdlib/plot/sparklines/unicode/line/lib/render.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@

// MODULES //

var falses = require( '@stdlib/array/base/falses' );
var zeros = require( '@stdlib/array/base/zeros' );
var abs = require( '@stdlib/math/base/special/abs' );
var round = require( '@stdlib/math/base/special/round' );
var PINF = require( '@stdlib/constants/float64/pinf' );
Expand Down Expand Up @@ -85,8 +87,8 @@
glyphs = UNICODE_BRAILLE_ELEMENTS;
}
// Assign each datum to a bin...
idx = new Array( len );
FLG = new Array( len );
idx = zeros( len );
FLG = falses( len );
n = glyphs.length - 1;
for ( i = 0; i < len; i++ ) {
d = this._data[ i ];
Expand All @@ -110,8 +112,8 @@
idx[ i ] = j;
}

// TODO: color encoding: one color for both pos and neg or two colors for separate colors

Check warning on line 115 in lib/node_modules/@stdlib/plot/sparklines/unicode/line/lib/render.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: color encoding: one color for both...'
// TODO: negative values diff color (red)

Check warning on line 116 in lib/node_modules/@stdlib/plot/sparklines/unicode/line/lib/render.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: negative values diff color (red)'

// For each datum, we peek ahead to determine if the next value is greater than or less than the current value. The magnitude of the difference determines the glyph slope.
str = '';
Expand Down