test: migrate math/base/special/coth to ULP-based testing#13635
Merged
Conversation
Replaces the EPS-based relative-tolerance comparisons in test.js and test.native.js with @stdlib/assert/is-almost-same-value, using the minimum required ULP values verified against the fixtures. Resolves a part of #11352.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
marked this pull request as ready for review
July 24, 2026 05:17
kgryte
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
test/test.jsandtest/test.native.jsinmath/base/special/cothfrom relative-tolerance (EPS-based) assertions to ULP-difference assertions via@stdlib/assert/is-almost-same-value, using the minimum required ULP values verified by direct ULP-difference computation over all test fixtures: thedatafixture requires a maximum ULP of2; thetiny_negative,tiny_positive,large_negative, andlarge_positivefixtures match exactly and thus use plaint.strictEqual.2was confirmed to be the tightest bound (an ULP of1produces failures across thedatafixture); the test suite was run twice at the final bound to confirm no flakiness.The native (C) addon could not be built/exercised in this environment (no prebuilt addon present and native module builds are unavailable here), so
test.native.jswas updated to mirror the same tolerances astest.js, consistent with the precedent set by prior conversions of the closely-relatedsinh/cschpackages, which found no JS-vs-C divergence for this class of function.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code (running as an unattended scheduled task), including the test migration and the computation/verification of minimum ULP tolerances directly against the fixtures.
@stdlib-js/reviewers
Generated by Claude Code