test: migrate math/base/special/atandf to ULP-based testing#13639
Closed
Planeshifter wants to merge 1 commit into
Closed
test: migrate math/base/special/atandf to ULP-based testing#13639Planeshifter wants to merge 1 commit into
math/base/special/atandf to ULP-based testing#13639Planeshifter wants to merge 1 commit into
Conversation
Resolves a part of #11352.
Contributor
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request migrates
test/test.jsandtest/test.native.jsofmath/base/special/atandffrom relative-tolerance (EPS-based) assertions to ULP-difference assertions via@stdlib/number/float32/base/assert/is-almost-same-value, following the merged precedent for single-precision packages (e.g.math/base/special/hypotf, PR #12808).delta/tol/EPS/absf-based tolerance checks in both the "negative values" and "positive values" test cases witht.strictEqual( isAlmostSameValue( y, e, 1 ), true, 'returns expected value' ).absfandEPSrequires; keeps the existingfloat64ToFloat32coercion of fixture expected values (unchanged from before).1for both the JavaScript and native implementations, verified by direct ULP-difference computation over both fixture files (negative.json,positive.json; combined 4009 assertions). The native add-on was built locally (make install-node-addons NODE_ADDONS_PATTERN=atandf) and its outputs were independently checked for max ULP difference against the fixtures (native negative: 1, native positive: 1; JS negative: 1, JS positive: 1).make test TESTS_FILTER=".*/math/base/special/atandf/.*") at ULP=1 to confirm deterministic passing (4009/4009 both runs, both files).npx eslintis clean on both changed files.Related Issues
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by an automated Claude Code agent running as a scheduled task, following the conventions established in prior merged ULP-migration PRs for this issue (e.g. #12808, #12799).
@stdlib-js/reviewers
Generated by Claude Code