chore: clean-up#13643
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CcfqHPLE5kNhYPv3GmVwJ1
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CcfqHPLE5kNhYPv3GmVwJ1
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CcfqHPLE5kNhYPv3GmVwJ1
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
…n/penalties/package.json
kgryte
marked this pull request as ready for review
July 24, 2026 21:56
kgryte
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween4b25135(2026-07-23, 20:59 PT) andfd3be1e(2026-07-23, 23:32 CT).This pull request:
stats/base/dists/binomial/logpmf:STDLIB_MATH_BASE_NAPI_MODULE_DID_D( stdlib_base_dists_binomial_logpmf )inlogpmf/src/addon.c, introduced in 34af926. Every otheraddon.c(e.g.,binomial/pmf,binomial/quantile) omits it; leaving it in produces a stray empty declaration under-pedantic.x[i]→x[ i ], etc.) inlib/node_modules/@stdlib/stats/base/dists/binomial/logpmf/test/test.native.jsacross 24 lines, introduced in 34af926; brings it in line with the style guide and the siblingbinomial/pmf/test/test.native.js.stats/base/dists/binomial/quantile:@paramline forpinlib/node_modules/@stdlib/stats/base/dists/binomial/quantile/lib/native.js:34, introduced in fd3be1e; collapsed to single space to match the surrounding@paramlines.r[i]→r[ i ], etc.) inbinomial/quantile/test/test.native.jsadded by fd3be1e, bringing it in line with the style guide and the siblingbinomial/pmf/test/test.native.js.ml/base/sgd-classification/penalties:keywordsinlib/node_modules/@stdlib/ml/base/sgd-classification/penalties/package.json(da9af3d): merge separatesgdandclassificationentries intosgd classification, matching theloss-functionsandlearning-ratessiblings.Related Issues
No.
Questions
No.
Other
Validation performed on all six commits merged to
developin the review window (4b25135,44e1463,0204d5b,da9af3d,34af926,fd3be1e):docs/style-guidesand established reference packages (binomial/pmf,ml/base/sgd-classification/loss-functions,learning-rates).quantile;binomcoefln-basedlogpmf), N-API macro/signature agreement, JS↔C enum consistency in the newpenaltiespackage, manifest/build config, and doc-example outputs. No runtime bugs found; the doc-example values were verified numerically.quantile/test/test.main.js, which predate the window).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated post-merge review routine: it audited the last 24 hours of commits to
developfor bugs and style-guide violations and applied the validated fixes. All changes were cross-verified against the stdlib style guides and reference packages.🤖 Generated with Claude Code
https://claude.ai/code/session_01CcfqHPLE5kNhYPv3GmVwJ1
Generated by Claude Code