Skip to content

chore: clean-up#13643

Merged
kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-07-24
Jul 24, 2026
Merged

chore: clean-up#13643
kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-07-24

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 4b25135 (2026-07-23, 20:59 PT) and fd3be1e (2026-07-23, 23:32 CT).

This pull request:

  • stats/base/dists/binomial/logpmf:
    • Removed the trailing semicolon after STDLIB_MATH_BASE_NAPI_MODULE_DID_D( stdlib_base_dists_binomial_logpmf ) in logpmf/src/addon.c, introduced in 34af926. Every other addon.c (e.g., binomial/pmf, binomial/quantile) omits it; leaving it in produces a stray empty declaration under -pedantic.
    • Fixed unspaced array indices (x[i]x[ i ], etc.) in lib/node_modules/@stdlib/stats/base/dists/binomial/logpmf/test/test.native.js across 24 lines, introduced in 34af926; brings it in line with the style guide and the sibling binomial/pmf/test/test.native.js.
  • stats/base/dists/binomial/quantile:
    • Fix double-space typo in JSDoc @param line for p in lib/node_modules/@stdlib/stats/base/dists/binomial/quantile/lib/native.js:34, introduced in fd3be1e; collapsed to single space to match the surrounding @param lines.
    • Fixed spacing around array indices (r[i]r[ i ], etc.) in binomial/quantile/test/test.native.js added by fd3be1e, bringing it in line with the style guide and the sibling binomial/pmf/test/test.native.js.
  • ml/base/sgd-classification/penalties:
    • Fix keywords in lib/node_modules/@stdlib/ml/base/sgd-classification/penalties/package.json (da9af3d): merge separate sgd and classification entries into sgd classification, matching the loss-functions and learning-rates siblings.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation performed on all six commits merged to develop in the review window (4b25135, 44e1463, 0204d5b, da9af3d, 34af926, fd3be1e):

  • Style-guide compliance audit (two independent passes) against docs/style-guides and established reference packages (binomial/pmf, ml/base/sgd-classification/loss-functions, learning-rates).
  • Bug scan (two independent passes) covering algorithm correctness of the new C implementations (Cornish–Fisher guess + directional search for quantile; binomcoefln-based logpmf), N-API macro/signature agreement, JS↔C enum consistency in the new penalties package, manifest/build config, and doc-example outputs. No runtime bugs found; the doc-example values were verified numerically.
  • Deliberately excluded: subjective concerns, anything requiring interpretation, and anything whose validation or fix would require touching code outside the window's diff (e.g., pre-existing unspaced indices in quantile/test/test.main.js, which predate the window).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of an automated post-merge review routine: it audited the last 24 hours of commits to develop for bugs and style-guide violations and applied the validated fixes. All changes were cross-verified against the stdlib style guides and reference packages.

🤖 Generated with Claude Code

https://claude.ai/code/session_01CcfqHPLE5kNhYPv3GmVwJ1


Generated by Claude Code

@stdlib-bot

stdlib-bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/binomial/logpmf $\\color{green}363/363$
$\\color{green}+0.00\\%$
$\\color{green}46/46$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}363/363$
$\\color{green}+0.00\\%$
stats/base/dists/binomial/quantile $\\color{red}522/524$
$\\color{green}+0.00\\%$
$\\color{red}61/62$
$\\color{green}+0.00\\%$
$\\color{green}6/6$
$\\color{green}+0.00\\%$
$\\color{red}522/524$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Jul 24, 2026
@kgryte
kgryte marked this pull request as ready for review July 24, 2026 21:56
@kgryte
kgryte requested a review from a team July 24, 2026 21:56
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 24, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 24, 2026
@kgryte kgryte changed the title style: fix code style and keywords in recently merged packages chore: clean-up Jul 24, 2026
@kgryte
kgryte merged commit 620be0b into develop Jul 24, 2026
49 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-07-24 branch July 24, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants