Support CLI on Windows by refactoring scripts to console_scripts#177
Open
RH-TLagrone wants to merge 1 commit intostefankoegl:masterfrom
Open
Support CLI on Windows by refactoring scripts to console_scripts#177RH-TLagrone wants to merge 1 commit intostefankoegl:masterfrom
RH-TLagrone wants to merge 1 commit intostefankoegl:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #176 by switching the jsondiff/jsonpatch CLIs from installed “scripts” to setuptools-generated console_scripts, which enables proper CLI installation on Windows.
Changes:
- Refactors packaging to define
console_scriptsentry points forjsondiffandjsonpatch. - Introduces new internal CLI modules:
jsonpatch._jsondiff_cliandjsonpatch._jsonpatch_cli. - Moves metadata parsing in
setup.pyto read fromjsonpatch/__init__.py.
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| setup.py | Replaces scripts=[...] with entry_points.console_scripts and updates module metadata source path. |
| jsonpatch/_jsondiff_cli.py | Adds the jsondiff CLI implementation used by the console script entry point. |
| jsonpatch/_jsonpatch_cli.py | Adds the jsonpatch CLI implementation used by the console script entry point. |
| jsonpatch/init.py | Adds the package module that provides the library implementation and metadata used by setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176