Fix arm64 image build for stellar-cli 25.2.0 - #35
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes arm64 publishing for Stellar CLI 25.2.0.
Changes:
- Updates the Rust base image to a multi-architecture index digest.
- Makes the refresh script executable.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
builds.json |
Corrects the 25.2.0 Rust image digest. |
scripts/refresh.py |
Adds executable permission. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leighmcculloch
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Corrects the rust base image pin for stellar-cli 25.2.0 in
builds.json, swapping the amd64-only manifest digest (4f5721…) for the real multi-arch index digest (64232e…) ofrust:1.90.0-slim-bookworm. Also marksscripts/refresh.pyexecutable, matching how RELEASE.md invokes it (./scripts/refresh.py).Why
The 25.2.0 pin pointed at a single-arch (amd64) child manifest rather than the multi-arch index. On amd64 the build succeeded, but the arm64 job pulled the amd64 image and failed at the first
RUNwithexec /bin/bash: exec format error(failed run). The correct index digest resolves both architectures; its amd64 child is identical to the previously pinned digest, so amd64 image content is unchanged.Notes
The corrected digest was verified as an image index (
application/vnd.oci.image.index.v1+json) andscripts/validate_json.pypasses. Re-run thev25.2.0release/publish flow to rebuild the arm64 image.