Sort entry pointers in convertToBucketEntry.#5291
Open
dmkozh wants to merge 1 commit into
Open
Conversation
This avoids O(n log n) swaps of potentially large structs.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates LiveBucket::convertToBucketEntry to sort pointers to BucketEntry objects (rather than sorting the BucketEntry objects themselves), aiming to reduce the cost of std::sort swapping large structs during bucket creation in Stellar Core’s bucket subsystem.
Changes:
- Build an unsorted
entriesvector ofBucketEntryobjects and a parallel vector of pointers to those objects. - Sort the pointer vector using the existing
BucketEntryIdCmp<LiveBucket>comparator. - Materialize the final sorted
bucketvector by moving elements in sorted pointer order.
Comment on lines
+389
to
+393
| std::vector<BucketEntry> entries; | ||
| entries.reserve(totalSize); | ||
|
|
||
| std::vector<BucketEntry*> sortedEntries; | ||
| sortedEntries.reserve(totalSize); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sort entry pointers in convertToBucketEntry.
This avoids O(n log n) swaps of potentially large structs.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)