make the git sha a link in slack notifications - #2709
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Slack build notifications to link commit SHAs.
Changes:
- Adds SHA links to success and failure messages.
- Uses unsupported Markdown syntax instead of Slack mrkdwn syntax.
Recommendation: NEEDS-CHANGES — use <URL|SHA> formatting in both messages.
Comments suppressed due to low confidence (1)
.github/workflows/build-and-push.yml:75
- Slack
chat.postMessagedoes not turn[label](URL)into a link; its mrkdwn format requires<URL|label>. This failure notification therefore will not render the SHA as the intended link.
"text": "Docs build failed for [${{ github.sha }}](${{ github.server_url }}/${{ github.repository }}/commit/${{ github.sha }})."
|
Preview is available here: |
|
Preview is available here: |
kaankacar
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a totally superficial change, but it should render the slack notifications in the
#docs-buildschannel a little nicer 🤞🏻