Skip to content

ci: guide SEP change PRs to engage authors - #1986

Merged
marcelosalloum merged 10 commits into
masterfrom
sep-modification-guidance
Jul 28, 2026
Merged

ci: guide SEP change PRs to engage authors#1986
marcelosalloum merged 10 commits into
masterfrom
sep-modification-guidance

Conversation

@marcelosalloum

@marcelosalloum marcelosalloum commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

What

  • Add a workflow that converts PRs modifying existing SEPs to draft (without locking) and posts a guidance comment.
  • The comment links each modified SEP's existing Discussion: thread and @-mentions its original authors, parsed from the preamble Author: line (only valid GitHub handles; plain names, emails, and org authors are skipped).

Why

  • Per the SEP Contribution Process, changes to an existing SEP should start as a discussion and be advocated with the SEP's author(s) — this automates that guidance.
  • Draft status reserves "ready for review" to mean the change has been discussed and a maintainer should review and merge.

When it triggers

  • pull_request_target on opened/reopened for PRs that modify existing ecosystem/sep-*.md files.
  • Defers to the New SEP Proposal workflow when the PR adds a new SEP; posts at most once per PR (idempotency marker).

Example comment

For a PR by @somecontributor modifying sep-0038.md:

👋 Thanks for your contribution!

This PR proposes changes to the following existing SEP(s):

Per the SEP Contribution Process, changes to an existing SEP should start as a discussion, and should be advocated with the SEP's author(s) — the author maintains the proposal, so engaging them is an important part of getting a change adopted. If you haven't already, please raise your proposed change on the SEP's existing discussion linked above, or start one on the GitHub discussion forum.

I have marked this PR as a draft for now. Once the change has been discussed and is ready for a maintainer to review and merge, mark it as ready for review.

Thanks for helping improve the Stellar ecosystem! 🚀

@marcelosalloum
marcelosalloum marked this pull request as ready for review July 24, 2026 21:19
Copilot AI review requested due to automatic review settings July 24, 2026 21:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds automation to guide pull requests that modify existing SEPs through the contribution process.

Changes:

  • Detects modified SEP files and extracts authors/discussion links.
  • Converts qualifying PRs to drafts.
  • Posts idempotent contribution guidance.

Comment thread .github/workflows/sep-modification.yml
Comment thread .github/workflows/sep-modification.yml Outdated
Comment thread .github/workflows/sep-modification.yml Outdated
Comment thread .github/workflows/sep-modification.yml Outdated
leighmcculloch
leighmcculloch previously approved these changes Jul 24, 2026
@leighmcculloch

Copy link
Copy Markdown
Member

Could we add a comment to the top highlighting it is critical the job does not check out pr data?

@marcelosalloum
marcelosalloum force-pushed the sep-modification-guidance branch from 2410683 to 06f5a96 Compare July 27, 2026 16:09
@marcelosalloum
marcelosalloum enabled auto-merge (squash) July 27, 2026 16:12
leighmcculloch
leighmcculloch previously approved these changes Jul 27, 2026
Comment thread .github/workflows/sep-modification.yml Outdated
Comment thread .github/workflows/sep-modification.yml
Comment thread .github/workflows/sep-modification.yml
Co-authored-by: Leigh <351529+leighmcculloch@users.noreply.github.com>
Comment thread .github/workflows/sep-modification.yml Outdated
@marcelosalloum
marcelosalloum disabled auto-merge July 28, 2026 15:55
@marcelosalloum
marcelosalloum merged commit d0f9dd8 into master Jul 28, 2026
6 checks passed
@marcelosalloum
marcelosalloum deleted the sep-modification-guidance branch July 28, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants