Skip to content

Add generic F103Cx targets#1037

Merged
fpistm merged 1 commit into
stm32duino:masterfrom
MCUdude:Generic_F103Cx
Apr 21, 2020
Merged

Add generic F103Cx targets#1037
fpistm merged 1 commit into
stm32duino:masterfrom
MCUdude:Generic_F103Cx

Conversation

@MCUdude
Copy link
Copy Markdown
Contributor

@MCUdude MCUdude commented Apr 19, 2020

This adds generic F103C4, F103C6, F103C8 and F103CB targets.

@MCUdude
Copy link
Copy Markdown
Contributor Author

MCUdude commented Apr 19, 2020

@fpistm For some strange reason, the CI fails when trying to compile BareMinimum for F103C4 (not enough space). However, it compiles just fine in my Arduino IDE install.

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Apr 20, 2020

mpile BareMinimum for F103C4 (not enough space). However, it compiles just fine in my Arduino IDE install.

The sketch BareMinimum of the CI use several API to test the build that's why it does not fit in the FLASH, anyway it should be considered as succeeded with a '*'.
I will fix that.

@fpistm
Copy link
Copy Markdown
Member

fpistm commented Apr 20, 2020

@MCUdude
I've fix the issue with the CI: 6eaa8d2

If you rebase your PR on top of the master this would be ok.

@MCUdude
Copy link
Copy Markdown
Contributor Author

MCUdude commented Apr 20, 2020

Thanks, it should be OK now. I forgot to add the new targets to README, so I did another rebase and got everything into one commit, which I know you prefer 😉

@fpistm fpistm added the new variant Add support of new bard label Apr 21, 2020
@fpistm fpistm added this to the 1.9.0 milestone Apr 21, 2020
@fpistm fpistm self-requested a review April 21, 2020 07:38
Copy link
Copy Markdown
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I will review all system clock config to unified them and handle HSE, HSE by pass and HSI

@fpistm fpistm merged commit ab99a7b into stm32duino:master Apr 21, 2020
@MCUdude
Copy link
Copy Markdown
Contributor Author

MCUdude commented Apr 21, 2020

I will review all system clock config to unified them and handle HSE, HSE bypass, and HSI

Great! That should be the same for all F103 targets I believe. I also have an F103Vx pinout ready I may be able to publish a PR this evening. IIRC this variant has been requested earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new variant Add support of new bard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants