HardwareTimer: Fix ARR and CCRx computation#902
Merged
fpistm merged 1 commit intoJan 30, 2020
Conversation
matthijskooijman
approved these changes
Jan 30, 2020
Contributor
matthijskooijman
left a comment
matthijskooijman
left a comment
There was a problem hiding this comment.
Left one inline suggestion for improvement, but otherwise looks good!
* protect setOverflow against underflow. * remove -1 for MICROSEC_COMPARE_FORMAT, HERTZ_COMPARE_FORMAT and TICK_COMPARE_FORMAT. * remove -1 in setCount() too * Manage special case where ARR = MAX_RELOAD and 100% expected. Fixes stm32duino#897
ABOSTM
force-pushed
the
HARDWARE_TIMER_ARR_CCRx_COMPUTATION
branch
from
0b38f85 to
29767ba
Compare
fpistm
approved these changes
Jan 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HardwareTimer: Fix ARR and CCRx computation
Fixes #897