Skip to content

misc: Vagrantfile removal and missing pgi-docgen dependencies added to PythonDocs.Dockerfile #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vojtechtrefny merged 2 commits into from
Oct 1, 2025
Merged

misc: Vagrantfile removal and missing pgi-docgen dependencies added to PythonDocs.Dockerfile #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5b1e95
misc: Remove custom Vagrantfile
vojtechtrefny Sep 30, 2025
55a63b2
misc: Add some missing dependencies for pgi-docgen
vojtechtrefny Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion misc/PythonDocs.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ RUN echo "deb-src http://deb.debian.org/debian testing main" >> /etc/apt/sources
RUN apt-get update

# pgi-docgen dependencies
RUN apt-get -y install python3 python3-pip python3-jinja2 python3-sphinx python3-bs4 python3-graphviz libgirepository-1.0-1 gir1.2-glib-2.0
RUN apt-get -y install python3 python3-pip python3-jinja2 python3-sphinx python3-bs4 python3-graphviz libgirepository-1.0-1 libgirepository1.0-dev gir1.2-glib-2.0 gir1.2-glib-2.0-dev
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to adhere to Dockerfile best practices, I suggest a few improvements:

  1. Split the long list of packages into multiple lines, sorted alphabetically. This improves maintainability.
  2. Add the --no-install-recommends flag to apt-get install to reduce the final image size.

As a future improvement for this file, consider combining all apt-get commands into a single RUN layer to optimize caching and further reduce image size.

RUN apt-get -y install --no-install-recommends \
    gir1.2-glib-2.0 \
    gir1.2-glib-2.0-dev \
    libgirepository-1.0-1 \
    libgirepository1.0-dev \
    python3 \
    python3-bs4 \
    python3-graphviz \
    python3-jinja2 \
    python3-pip \
    python3-sphinx


RUN apt-get -y install git

Expand Down
65 changes: 0 additions & 65 deletions misc/Vagrantfile
View file
Open in desktop

This file was deleted.