Skip to content

Upgrade to Electron 43 - #56

Merged
sandboxcoder merged 4 commits into
streamlabsfrom
rno/electron-upgrade
Aug 24, 2026
Merged

Upgrade to Electron 43#56
sandboxcoder merged 4 commits into
streamlabsfrom
rno/electron-upgrade

Conversation

@sandboxcoder

Copy link
Copy Markdown
Contributor
  • Update README with instructions for MacOS
  • Update ci/build-osx.sh to define default env vars so we can run this locally

* Update README with instructions for MacOS
* Update ci/build-osx.sh to define default env vars so we can run this
locally

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the native addon and CI toolchain to Electron 43.2.0 and adds macOS build guidance.

Changes:

  • Updates Electron, Node.js, CMake headers, dependencies, and CI configuration.
  • Adds macOS build instructions and configurable script defaults.
  • Adjusts macOS deployment-target configuration.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Review notes Severity
yarn.lock Yarn 4 lockfile is not supported without pinning Yarn/Corepack or regenerating with the supported version. Moderate
README.md Install dependencies before running the build script; also fix the “Administrator” misspelling. Nit
package.json No final review comments.
CMakeLists.txt The script’s unconditional macOS deployment-target override prevents the arm64 11.0 target from being used. Moderate
ci/build-osx.sh BUILD_DIRECTORY is not used consistently, causing builds and artifact paths to diverge for non-default directories. Moderate
.github/workflows/build.yml No final review comments.
Suppressed comments (1)

README.md:18

  • The new local command is not self-contained: build-osx.sh unconditionally invokes sentry-cli --auth-token ${SENTRY_AUTH_TOKEN} under set -e, but this section never tells the user to provide SENTRY_AUTH_TOKEN or skip symbol upload. A fresh local run will therefore fail after the build; document the token requirement or make the upload conditional when the token is unset.
ci/build-osx.sh

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CMakeLists.txt Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread ci/build-osx.sh Outdated
@sandboxcoder
sandboxcoder merged commit f5bd46f into streamlabs Aug 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants