Upgrade to Electron 43 - #56
Merged
Merged
Conversation
sandboxcoder
commented
Aug 24, 2026
Contributor
- Update README with instructions for MacOS
- Update ci/build-osx.sh to define default env vars so we can run this locally
* Update README with instructions for MacOS * Update ci/build-osx.sh to define default env vars so we can run this locally
sandboxcoder
force-pushed
the
rno/electron-upgrade
branch
from
August 24, 2026 20:04
4125359 to
f79a4ee
Compare
There was a problem hiding this comment.
Pull request overview
Upgrades the native addon and CI toolchain to Electron 43.2.0 and adds macOS build guidance.
Changes:
- Updates Electron, Node.js, CMake headers, dependencies, and CI configuration.
- Adds macOS build instructions and configurable script defaults.
- Adjusts macOS deployment-target configuration.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Review notes | Severity |
|---|---|---|
yarn.lock |
Yarn 4 lockfile is not supported without pinning Yarn/Corepack or regenerating with the supported version. | Moderate |
README.md |
Install dependencies before running the build script; also fix the “Administrator” misspelling. | Nit |
package.json |
No final review comments. | — |
CMakeLists.txt |
The script’s unconditional macOS deployment-target override prevents the arm64 11.0 target from being used. | Moderate |
ci/build-osx.sh |
BUILD_DIRECTORY is not used consistently, causing builds and artifact paths to diverge for non-default directories. |
Moderate |
.github/workflows/build.yml |
No final review comments. | — |
Suppressed comments (1)
README.md:18
- The new local command is not self-contained:
build-osx.shunconditionally invokessentry-cli --auth-token ${SENTRY_AUTH_TOKEN}underset -e, but this section never tells the user to provideSENTRY_AUTH_TOKENor skip symbol upload. A fresh local run will therefore fail after the build; document the token requirement or make the upload conditional when the token is unset.
ci/build-osx.sh
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
* this is already explicitly passed into CMake
summeroff
approved these changes
Aug 24, 2026
aleksandr-voitenko
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.