fix: wire up ref correctly for PMME#2418
Closed
tjclawson-stripe wants to merge 1 commit into
Closed
Conversation
Contributor
|
So I'm closing #2418? Does this repo no longer accept PR from the community? |
porter-stripe
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept ref from forwardRef callback and pass to native element
Motivation
The component used forwardRef but ignored the forwarded ref parameter. Instead, it created its own internal useRef (viewRef) and passed that to the native element. This meant any consumer passing a ref to would get nothing — the ref was silently dropped
Testing
Documentation
Select one: