Fix PaymentMethodMessagingElement forwardRef warning#2436
Merged
tjclawson-stripe merged 5 commits intoMay 18, 2026
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
tjclawson-stripe
previously approved these changes
May 11, 2026
Collaborator
|
Hey @cyxmon, thanks for this PR! Can you run |
…hange Run yarn api-extractor:update so etc/stripe-react-native.api.md matches the removed forwardRef export shape. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Thanks for the callout. I ran yarn api-extractor:update and committed the resulting public API surface update. |
tjclawson-stripe
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forwardReffromPaymentMethodMessagingElementbecause the component only uses an internal native view ref.forwardRefreceiving a render function with only one parameter.Test plan
yarn prettier --write src/components/PaymentMethodMessagingElement.tsxyarn typescriptyarn lint --quiet src/components/PaymentMethodMessagingElement.tsxMade with Cursor