Updates Android SDK to 23.8.0 + CryptoOnramp SDK EU Support#2441
Merged
Conversation
mliberatore
added a commit
to stripe/stripe-ios
that referenced
this pull request
May 7, 2026
…Sheet to @_spi(CryptoOnrampAlpha) (#6401) ## Summary There are a few APIs in `StripePaymentSheet` that were exposed only for `StripeCryptoOnramp`. We want to remove `@_spi(STP)` usage from React Native, and that requires migrating these to `@_spi(CryptoOnrampAlpha)`. These changes are in: - `LinkAppearance.swift` - `VerifyKYCResult.swift` - `STPImageLibrary.swift` All other changes here are correcting the relevant imports to ensure a clean build. ## Motivation This request came from Jean in Slack. ## Testing - Allowed CI to build and run all tests. - Tested locally with stripe/stripe-react-native#2441 in the React Native project. ## Changelog ✅ <!-- Is this a notable change that affects users? If so, add a line to `CHANGELOG.md` and prefix the line with one of the following: - [Added] for new features. - [Changed] for changes in existing functionality. - [Deprecated] for soon-to-be removed features. - [Removed] for now removed features. - [Fixed] for any bug fixes. - [Security] in case of vulnerabilities. -->
…-onramp-spi # Conflicts: # ios/StripeSdkImpl.swift
…ripe/stripe-react-native into mliberatore/crypto-onramp-spi
mliberatore
changed the base branch from
master
to
mliberatore/25.14.0-update-ios
…ripe/stripe-react-native into mliberatore/crypto-onramp-spi
…essionBetaAccess` imports
mliberatore
changed the title
…-onramp-spi # Conflicts: # ios/StripeSdkImpl.swift
mliberatore
commented
May 14, 2026
|
|
||
| - tapOn: | ||
| text: "Card number" | ||
| text: "Card number. Supported cards include.*" |
Collaborator
Author
There was a problem hiding this comment.
Looks like this was a recently added test, and it's failing on master for the same reason as those fixed in https://github.com/stripe/stripe-react-native/pull/2457/changes#r3235956032, so fixing here.
jeanregisser
previously approved these changes
May 14, 2026
| export type CRSCARFDeclarationResult = | ||
| | { | ||
| /** The customer accepted the declaration. */ | ||
| status: 'Confirmed'; |
Member
There was a problem hiding this comment.
nit: can we use lowercase status? Or is Capitalization a convention we're already using?
Suggested change
| status: 'Confirmed'; | |
| status: 'confirmed'; |
Collaborator
Author
There was a problem hiding this comment.
A convention we're already using across Onramp (we have Consented, Denied, Confirmed, UpdateAddress statuses). I’m not opposed to us shifting to lowercase across the board, but we should plan that accordingly in isolation and discuss client impact if we'd like to do that.
| if let identifierError = error as? Mappers.ComplianceIdentifierError, | ||
| case let .invalidField(field) = identifierError { | ||
| let errorResult = Errors.createError(ErrorType.Unknown, "Invalid format for field: \(field)") | ||
| resolve(["error": errorResult["error"]!]) |
Member
There was a problem hiding this comment.
Nothing to do now, but this is also where we'll want to apply the richer error proposal that we've been discussing.
finn-stripe
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR, based on #2457, updates the Android SDK, and adds the iOS + Android bindings for CryptoOnramp SDK EU support. These EU additions are exercised in the example app flow changes.
Motivation
Keeping up-to-date with the latest native SDK releases.
Testing
Tested using the example app. It is expected in testmode that the declaration screen is showing a dummy response (HTML) currently.
Documentation
Select one: