Add CurrencySelectorElement (JS)#2445
Merged
Merged
Conversation
Adds the TypeScript layer for the currency selector feature: - CurrencySelectorElement component with native view spec - checkoutSessionDidChangeState event listener in useCheckout - NativeCurrencySelectorElement codegen spec - New arch component mapping in package.json Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
Avoids a potential layout flash on mount where the view briefly takes up unconstrained space before the first onHeightChange event fires. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
No imperative methods are exposed, so forwardRef adds noise with no benefit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Committed-By-Agent: claude
porter-stripe
commented
May 7, 2026
| * @category ReactComponents | ||
| * @internal | ||
| */ | ||
| export function CurrencySelectorElement({ |
Collaborator
Author
There was a problem hiding this comment.
Going to export this from index.ts once we are ready to release.
tjclawson-stripe
approved these changes
May 11, 2026
porter-stripe
added a commit
that referenced
this pull request
May 12, 2026
Resolves conflicts from the JS and iOS PRs that landed on master: - Android stub files added in #2445 are replaced by this branch's full Compose-based CurrencySelectorElement implementation. - src/components/CurrencySelectorElement.tsx uses master's post-review form (no forwardRef, height initialized to 0). - src/hooks/useCheckout.tsx keeps master's simpler comment on the checkoutSessionDidChangeState listener. Verified ./gradlew :app:assembleDebug builds successfully. Co-authored-by: Cursor <cursoragent@cursor.com> Committed-By-Agent: cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Usage
Motivation
Testing
Documentation
N/A