fix(isthmus): support variadic concat conversion#1001
Merged
nielspardon merged 1 commit intoJul 13, 2026
Conversation
Nest Substrait concat arguments into binary Calcite calls while preserving operand order. Closes substrait-io#724.
nielspardon
approved these changes
Jul 13, 2026
nielspardon
left a comment
Member
There was a problem hiding this comment.
LGTM, the only issue this introduces is that we can not cleanly round-trip plans Substrait -> Calcite -> Subtrait if the initial Substrait plan contained a variadic concat function call. I don't think there is an elegant way to solve this during conversion and maybe should be considered in the semantic-aware plan comparison issue #994
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert variadic Substrait
concatexpressions into left-associated binary Calcite calls. This preserves argument order while satisfying Calcite||operand-count validation.Closes #724.
Changes
Repro
Converting
concat("a", "b", "c")previously passed three operands to Calcite||and failed withwrong operand count 3 for ||. It now producesconcat(concat("a", "b"), "c").Testing
./gradlew :isthmus:test --tests io.substrait.isthmus.FunctionConversionTest./gradlew spotlessApply./gradlew build --rerun-tasksLocal
integrationTestcould not start because no Docker daemon is available; GitHub Actions runs that Testcontainers suite.Did this cause any problems?
No. Revert this commit to restore previous conversion behavior.