Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions IMPROVEMENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ Analysis performed on the current codebase (~11K LOC across 62+ library files, 5

## High Priority

### 0. Pinned dependencies

Never update "chai-http" to newer version, this would require significant rewrite for whole test suite.

### 1. Replace `console.log` with a Structured Logger
**Effort:** Medium (2–3 days)
**Owner:** THiNX backend maintainers
Expand Down
2 changes: 1 addition & 1 deletion builders/arduino-docker-build
2 changes: 1 addition & 1 deletion builders/micropython-docker-build
2 changes: 1 addition & 1 deletion builders/mongoose-docker-build
2 changes: 1 addition & 1 deletion builders/nodemcu-docker-build
4 changes: 2 additions & 2 deletions lib/thinx/statistics.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ module.exports = class Statistics {
if (fs.existsSync(this.TEMP_PATH)) {
try {
fs.unlink(this.TEMP_PATH);
} catch (e) {
} catch (_e) {
logger.debug(`unlinking ${this.TEMP_PATH} failed`);
}
}
Expand Down Expand Up @@ -374,7 +374,7 @@ module.exports = class Statistics {

try {
fs.unlink(this.TEMP_PATH);
} catch (e) {
} catch (_e) {
// can throw if not exists
}

Expand Down
Loading