Added extra slice hook useful for downstream#944
Open
nabobalis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
any NDCube subclass holding axis-tracking state that NDMeta's generic slicing can't express (per-frame WCS lists, instrument lookup tables that change meaning when an axis collapses) currently must override getitem, duplicate the mixin's ellipsis/sanitize logic, and hope upstream slicing internals don't shift under them. One no-op hook removes that entire class of override.
ALL TO MAKE MY IRISPY PR SMALLER.
AI Assistance Disclosure
AI tools were used for: