fix(api): reject empty email action links#2569
Open
pjpjq wants to merge 1 commit into
Open
Conversation
pjpjq
changed the title
pjpjq
force-pushed
the
codex/error-on-noop-admin-links
branch
from
90d3ed6 to
126e72b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
GetEmailActionLinkas an internal error.POST /admin/generate_linkfrom returning a successful response with an emptyaction_link.Why
Self-hosted or custom no-op mailer paths should fail clearly instead of silently returning a successful response that cannot be used.
Fixes #263.
Validation
go test ./internal/api -run 'TestMail/TestGenerateLink|TestMail/TestGenerateLinkReturnsErrorForEmptyActionLink' -count=1go test ./internal/api -run TestMail -count=1git diff --check