feat: add RS256 signing keys backed by AWS KMS#2571
Open
hf wants to merge 5 commits into
Open
Conversation
|
Found 6 test failures on Blacksmith runners: Failures
|
cstockton
requested changes
Jun 10, 2026
cstockton
left a comment
cstockton
left a comment
Contributor
There was a problem hiding this comment.
I think this is a good start but do see the need for some changes here.
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for RSA signing keys backed by AWS KMS, which are the cheapest type of key.
You specify
aws:kms:arnas a claim in the private key's JWK and it all flows from there. It uses the ambient credentials of the process to talk to KMS.