chore: enable Effect linting across monorepo - #6304
Conversation
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@6edaa03437c8b42aa41cf58f32e06474205f2a52Preview package for commit |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: edcae5572d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e49fe7db95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa1b421c7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
💡 Codex Reviewcli/apps/cli/src/shared/auth/jwks.ts Lines 266 to 268 in 2aefb88  Keep the JWKS timeout around body decoding
When an OIDC discovery or JWKS endpoint returns headers but stalls while sending its JSON body, the 10-second timeout has already completed because it wraps only AGENTS.md reference: apps/cli/AGENTS.md:L52-L53 cli/apps/cli/src/shared/functions/functions-docker.ts Lines 327 to 329 in 2aefb88 Preserve project dotenv Bitbucket detection
When AGENTS.md reference: apps/cli/AGENTS.md:L52-L53 cli/apps/cli/src/legacy/shared/legacy-db-dns.ts Lines 92 to 93 in 2aefb88 Keep DNS body reads tied to the abort signal
When the DNS-over-HTTPS server or an intervening proxy returns status 200 and then stalls the response body, this second AGENTS.md reference: AGENTS.md:L68-L72 cli/apps/cli/src/shared/runtime/command-runtime.layer.ts Lines 8 to 11 in 2aefb88 Retain UUID entropy for command run IDs
At fleet-scale CLI volume, replacing the UUID with one signed 32-bit AGENTS.md reference: apps/cli/AGENTS.md:L52-L53 Preserve extension fields on remote JWKs
When a third-party issuer publishes a valid JWK that relies on members outside this local signing-key schema, such as an RSA key represented through AGENTS.md reference: apps/cli/AGENTS.md:L52-L53 Drain NDJSON exports before command shutdown
When a short-lived command ends immediately after its final span, AGENTS.md reference: AGENTS.md:L115-L117 cli/packages/stack/src/platform-bun.ts Line 103 in 2aefb88 Extend Bun's control timeout through JSON decoding
When a stale daemon or another listener on a deterministic control port returns 200 headers but never completes its owner-status body, this 500 ms timeout ends as soon as ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Automated review round 3 triage (final bounded pass): Fixed in 435a2d3:
Confirmed but deferred from this PR after reaching the automated-review loop cap:
These deferrals are recorded here for human review rather than silently dropped. The selected fixes have focused regression coverage and the affected CLI/stack quality plus unit/integration gates pass locally. No further automated fix rounds are planned; this is ready for human review. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 435a2d36f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Final automated-review pass, including #6304 (comment), is addressed by 8bb6933.\n\nI validated each report against the actual Effect execution path and the previous Go behavior before changing code. All seven items in that report were reproducible or represented concrete compatibility regressions:\n\n- JWKS timeout now covers request execution, status validation, and JSON body decoding.\n- Resolved project environment values, including BITBUCKET_CLONE_DIR, now reach both function volume creation and bind-mount decisions in deploy, download, serve, and start.\n- DNS fetch and body decoding share one cancellation signal.\n- Command correlation IDs use the injected Crypto service for UUIDv4 values.\n- Remote JWK JSON is preserved losslessly, matching the Go RawMessage behavior; local signing keys remain strictly validated.\n- NDJSON export fibers are scoped, owned, and drained before teardown.\n- Bun control-request timeout now covers JSON body decoding too.\n\nThe four newer inline findings are also addressed: empty SUPABASE_ENV defaults to development, known environment-override validation failures stay in the typed error channel, the duplicate JWKS timeout report is covered by the same fix, and Node/Bun config facades preserve explicit empty ambient values.\n\nI considered pushback explicitly. None was warranted after reproduction: the two initially ambiguous cases—remote JWK extension fields and empty ambient environment values—were confirmed by the Go source and a direct config-loader reproduction. The fixes remain narrow; no compatibility shim or speculative abstraction was added. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bb69332f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 757ca02d82
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Final bounded automated-review pass is complete at cbd93af. Accepted and fixed:
Rejected after reproduction/architecture triage:
The earlier top-level review at issuecomment-5386062423 was addressed separately in 8bb6933 and documented in issuecomment-5387281854. All review threads are resolved, the local no-cache quality/unit/integration matrix passes, and the fresh GitHub code-quality, unit/integration, e2e, and preview workflows are green. We have reached the automated-review loop cap. Requesting human review; further automated findings should be triaged as signals rather than applied automatically. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cbd93af8a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cbd93af to
214426e
Compare
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
💡 Codex Review Narrow missing-file errors with Predicate.isTagged
Replace the direct AGENTS.md reference: AGENTS.md:L169-L175 Narrow the combined unlink error with Predicate.isTagged
Replace the direct AGENTS.md reference: AGENTS.md:L169-L175 cli/apps/cli/src/legacy/auth/legacy-credentials.layer.unit.test.ts Lines 588 to 589 in 214426e Assert Exit variants through Exit.isFailure
Use AGENTS.md reference: AGENTS.md:L169-L176 cli/apps/cli/src/shared/functions/serve.ts Lines 344 to 345 in 214426e Match filesystem watch events exhaustively
Replace these direct AGENTS.md reference: AGENTS.md:L169-L178 cli/apps/cli/src/next/commands/start/ui/dashboard-state.ts Lines 44 to 48 in 214426e Preserve interruption when the state stream shuts down
Handle only the expected stream failure here and return interruption or defects unchanged with AGENTS.md reference: AGENTS.md:L157-L165 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jgoux
added
the
run-ci
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2edae15c6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Automated P1 cleanup pass is complete in a7c282d. I accepted the five findings in issuecomment-5388858414 after checking their actual control-flow impact: both missing-file paths and combined unlink errors now use supported tagged predicates; the credentials tests use Exit helpers throughout; filesystem watch events are matched exhaustively; and dashboard state catches only typed stream failures so interruption and defects retain their semantics. The two newer inline regressions are also fixed: compiled builds restore their immutable build ID define, and injected project environment capture preserves the established unprefixed Kong and Vector overrides. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7c282d0b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d12a47a5f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
avallete
left a comment
avallete
left a comment
There was a problem hiding this comment.
Reviewed the unique delta vs feat/remote-stack-control-plane (not the #6303 RPC transport). Lint wiring looks right, and most remediations are careful. Two things still matter before this can land.
env() interpolation lost ambient shell values. Effect loadProjectConfig no longer defaults to process.env when projectEnv is omitted. Call sites that were not updated — next start/status/functions dev/branches switch, config push, gen signing-key/bearer-jwt, plus functions-dev-config.ts switching to baseEnv: {} — now ignore shell/CI overrides. The test named “falls back to ambient process.env when .env is missing” was rewritten to inject projectEnv, so it no longer locks the old contract. Thread already-collected env (ProjectContext.projectEnv, collectConfigEnvironment) into those callers; do not put process.env back in the config core.
Branch does not merge onto current #6303. Conflicts in build.ts, version.ts, switch.integration.test.ts, build-identity.integration.test.ts (modify/delete), RemoteStack.ts, SupervisorReplacement.ts, supervisor.ts, and supervisor-child.ts. These are shared-file overlap with the parent, not lint-only drift.
Record-mode replay-server writes are also still racy across fixture keys and undrained on stop(); default replay CI is fine.
Parked: SSO metadata timeout-through-body (same shape on the parent), functions temp-dir cleanup, PortAllocator Date.now() staleness, and the rejected encodeUnknownSync / Path runSync items.
d12a47a to
49f8b22
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6edaa03437
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (yield* loadProjectEnvironment({ | ||
| cwd: projectRoot, | ||
| baseEnv: process.env, | ||
| search: options?.search, |
There was a problem hiding this comment.
When a consumer calls the public Node or Bun loadProjectConfig facade without projectEnv, a shell-only variable referenced by env(...) is no longer available here: both facades still call store.load directly, so numeric fields can fail decoding and string fields retain the literal reference. Fresh evidence after the earlier env-propagation comments is that the final facades—and direct callers such as gen types—still bypass the environment-materializing path; collect the ambient environment at those composition boundaries and pass it as projectEnv.
AGENTS.md reference: AGENTS.md:L101-L108
Useful? React with 👍 / 👎.
| const own = node._tag === "Value" || node.value === undefined ? [] : [entry(node.value)]; | ||
| if (node._tag === "Value") return [entry(node.value)]; | ||
| const children = | ||
| node._tag === "Record" |
There was a problem hiding this comment.
Replace these direct node._tag branches with Match.valueTags or another public exhaustive matcher. This newly added release-note environment collector knows the complete ConfigProvider node union statically, so inspecting its runtime representation and treating every non-Value/non-Record node as an Array violates the repository's Effect invariant and makes the maintenance script silently depend on internal representation details.
AGENTS.md reference: AGENTS.md:L169-L175
Useful? React with 👍 / 👎.
| @@ -1,12 +1,8 @@ | |||
| import { DateTime } from "effect"; | |||
| import type { Tracer } from "effect"; | |||
|
|
|||
| function formatTimestamp(ms: number): string { | |||
There was a problem hiding this comment.
On hosts outside UTC, DateTime.makeUnsafe(ms) creates a UTC value, so taking the time portion of its ISO representation shifts every telemetry debug timestamp by the host's offset. The previous formatter deliberately used Date#getHours/getMinutes/getSeconds, which displayed local wall-clock time; retain that behavior or convert the instant to the local zone before formatting.
AGENTS.md reference: apps/cli/AGENTS.md:L52-L53
Useful? React with 👍 / 👎.
2 participants
Summary
Reviewer context
This PR is stacked on #6303 and intentionally accepts its Effect RPC stack transport as the baseline. Merge #6303 first, then this PR. The stack changes here are lint remediation against that RPC design; they do not restore the prior transport implementation.
Enabling the recommended rules surfaced diagnostics across every TypeScript workspace, so this is intentionally a broad migration. Cleanup was limited to concrete ownership and lifecycle improvements; larger service-threading proposals without a demonstrated runtime benefit were rejected.