test: remove redundant schema existence checks - #2391
Open
pjpjq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_schemaassertions from the migration pgTAP suitemigrations/tests/database/test.sqlfocused on the remaining database privilege checksThe eight schemas are already covered by the Nix regression suite with stronger object/ACL snapshots:
public,graphql_public, andrealtime: schema/default ACL rows inroles.sql/roles.outauth: namespace owner and object snapshots inauth.sql/auth.outpgbouncer: namespace owner, function, and privilege snapshots inpgbouncer.sql/pgbouncer.outextensions: installed extension rows joined throughpg_namespaceinextensions_schema.sql/extensions_schema.outgraphql: directgraphql.resolve(...)calls inpg_graphql.sqlstorage: namespace owner, table, function, and ACL snapshots instorage.sql/storage.outTesting
supabase/postgres:17.6.1.107: 17/17 assertions passedgit diff --checkThe complete
migrations/tests/test.sqlwas also attempted in the same image, but the unmodified PostGIS extension setup failed before the changed database test include atpagc_normalize_address:function parse_address(character varying) does not exist.Fixes #1561