Skip to content

AMI: clean up nix at end of process - #2393

Merged
mmlb merged 1 commit into
developfrom
push-ouqsqsknlvtv
Aug 24, 2026
Merged

AMI: clean up nix at end of process#2393
mmlb merged 1 commit into
developfrom
push-ouqsqsknlvtv

Conversation

@mmlb

@mmlb mmlb commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

What kind of change does this PR introduce?

Maintenance

What is the current behavior?

Duplicate files are likely living in /nix/store.

What is the new behavior?

Duplicate files are hard linked.

Additional context

Saves some space.

@mmlb
mmlb requested review from a team as code owners August 24, 2026 14:48
@mmlb
mmlb marked this pull request as draft August 24, 2026 15:27
@mmlb

mmlb commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

Meant to be a draft until the testinfra ami builds run and I can see if there's any impact/worth putting up for review.

@mmlb

mmlb commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

ok here's the data (note to self, definitely want to diff develop and post as comment ...):

develop

AMI Root Disk Usage

Version Arch Human Bytes
15 amd64 7.6G 8065912832
15 arm64 7.3G 7783550976
17 amd64 7.1G 7573409792
17 arm64 6.8G 7299047424
orioledb-17 amd64 7.1G 7583776768
orioledb-17 arm64 6.9G 7309332480

This PR

AMI Root Disk Usage

Version Arch Human Bytes
15 amd64 7.2G 7713984512
15 arm64 7.0G 7431806976
17 amd64 6.8G 7208218624
17 arm64 6.5G 6933176320
orioledb-17 amd64 6.8G 7232512000
orioledb-17 arm64 6.5G 6943334400

Diff

AMI Root Disk Usage

Version Arch Human Bytes
15 amd64 336M 351928320
15 arm64 335M 351744000
17 amd64 348M 365191168
17 arm64 349M 365871104
orioledb-17 amd64 335M 351264768
orioledb-17 arm64 349M 365998080

@mmlb

mmlb commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

Yep worth it, adding to qemu too and then undrafting.

nix-collect-garbage probably doesn't do anything but also doesn't hurt,
nix-store --optimise is giving us ~342M back!
@mmlb
mmlb force-pushed the push-ouqsqsknlvtv branch from 8c53f47 to b670272 Compare August 24, 2026 16:09
@mmlb
mmlb marked this pull request as ready for review August 24, 2026 16:10
@mmlb
mmlb added this pull request to the merge queue Aug 24, 2026
Merged via the queue into develop with commit 2d90dc0 Aug 24, 2026
45 checks passed
@mmlb
mmlb deleted the push-ouqsqsknlvtv branch August 24, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants