fix(esign): align pdf config type with SuperDoc#3344
Merged
Conversation
superdoc-bot
Bot
added
review: careful
review: quick
and removed
review: careful
labels
Contributor
|
🎉 This PR is included in esign v2.5.1-next.1 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in esign v2.7.1 The release is available on GitHub release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PdfModuleConfigto satisfy SuperDoc's widened PDF module config type.pdfLibfromanytoobject, matching the SuperDoc module contract.Why
PR #3337 touches
packages/esign/.releaserc.cjs, which triggers eSign CI onmain. The eSign type check was failing because SuperDoc'sConfig.modules.pdfnow includesRecord<string, unknown>, while eSign's localPdfModuleConfigdid not.Validation
pnpm installpnpm run build:superdocpnpm --filter @superdoc-dev/esign type-checkpnpm --filter @superdoc-dev/esign lint(passes with existing warnings)pnpm --filter @superdoc-dev/esign buildpnpm --filter @superdoc-dev/esign test