Skip to content

fix: improve vml watermarks rendering#3470

Open
VladaHarbour wants to merge 3 commits into
mainfrom
sd-3265_vml-textbox
Open

fix: improve vml watermarks rendering#3470
VladaHarbour wants to merge 3 commits into
mainfrom
sd-3265_vml-textbox

Conversation

@VladaHarbour
Copy link
Copy Markdown
Contributor

@VladaHarbour VladaHarbour commented May 23, 2026

Improve parsing watermark opacity and font.
Word/Before comparison:
image

Fix applied:
Screenshot 2026-05-23 at 23 13 39

@VladaHarbour VladaHarbour self-assigned this May 23, 2026
@VladaHarbour VladaHarbour requested a review from a team as a code owner May 23, 2026 19:37
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 23, 2026

SD-3265

@github-actions
Copy link
Copy Markdown
Contributor

Status: PASS

The changes are all within the VML watermark importer (ECMA-376 Part 4) and don't introduce any spec violations. A quick rundown of what I checked:

  • parseVmlOpacity correctly handles the three forms VML allows for v:fill/@opacity: a plain fraction, a percentage (50%), and 16.16 fixed-point with f suffix (32768f32768/65536 = 0.5). That matches the VML ST_Fraction-style serialization. https://ooxml.dev/spec?q=fill
  • decodeXmlEntities on the v:textpath/@style value is benign — VML's style attribute carries CSS in an XML attribute, so "-escaped quotes around font-family are normal XML attribute escaping. Decoding them before the CSS parse is fine.
  • normalizeVmlColor only maps the standard VML named colors (black/blue/gray/green/lime/red/silver/white/yellow) to hex — those are all valid VML color names. https://ooxml.dev/spec?q=fillcolor
  • The other changes (textLength, lengthAdjust, fill-opacity, font fallback) are SVG output details, outside the OOXML surface.

Nothing here reads a non-existent VML attribute or assumes a wrong default for an OOXML element.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: def351e0ca

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants