Always insert db_version in cache#21
Merged
Merged
Conversation
Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
gorbak25
approved these changes
Mar 30, 2026
gorbak25
left a comment
gorbak25
left a comment
There was a problem hiding this comment.
lgtm! Will submit some tests for it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we'd only update the lastDbVersions map if it is bigger than what is currently in the database. This made the cache a little useless since it is cleared on commit/rollback and for most transaction, we'd be processing older db_versions. Now we'd set it to the biggest db_version encountered during the transaction so we don’t repeatedly attempt to update the db_version in the database.