fix(web): handle fulfilled external login errors - #1526
Open
abhinav7x94 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
result.errorcontract instead of relying only on rejected promises0transport errors as network failuresWhy
Better Auth 1.3.3 resolves non-2xx provider failures as
{ data: null, error }. It also converts fetch rejection into a fulfilled status-0error. The previous catch-only handlers ignored those results, leaving the login page permanently on “Redirecting…” with stale pending-login state.Validation
git diff --checkLanding note
This branch overlaps the web-test CI/dependency harness in #1498 and #1525. After either lands, rebase this PR and drop the duplicate harness hunks while retaining the login source and regression.