fix: preserve multiple Set-Cookie headers on 304 responses#15902
Open
MathiasWP wants to merge 2 commits into
Open
fix: preserve multiple Set-Cookie headers on 304 responses#15902MathiasWP wants to merge 2 commits into
MathiasWP wants to merge 2 commits into
Conversation
`Headers.get('set-cookie')` collapses multiple values into a single
comma-joined string that browsers cannot parse. Iterate
`Headers.getSetCookie()` and append each cookie individually so all
cookies survive an `If-None-Match` revalidation.
Fixes sveltejs#15527
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 0d56264 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15527.
Headers.get('set-cookie')collapses multiple values into a single comma-joined string that browsers cannot parse, so the 304 path was silently dropping all cookies after the first (most visible on non-Node adapters, wheresplitCookiesStringrecovery doesn't exist).Iterates
Headers.getSetCookie()and appends each cookie individually, matching the pattern already used byadd_cookies_to_headersincookie.js.Test plan
etag forwards multiple cookiesexercises the 304 path with three cookiesetag forwards cookiestest still passespnpm -F @sveltejs/kit test:unitpasses