[codex] Avoid state updates in preload tutorial effect#1977
Open
Sean-Kenneth-Doherty wants to merge 1 commit into
Open
[codex] Avoid state updates in preload tutorial effect#1977Sean-Kenneth-Doherty wants to merge 1 commit into
Sean-Kenneth-Doherty wants to merge 1 commit into
Conversation
|
@Sean-Kenneth-Doherty is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Problem
The preloading tutorial measures navigation timing by updating
$stateinside a$effect. Svelte guidance recommends avoiding state synchronization inside effects, and issue #1366 tracks this tutorial as an example that should be updated.Closes #1366.
Proposed Solution
Use SvelteKit navigation lifecycle callbacks instead:
beforeNavigatecaptures the navigation and start timeafterNavigaterecords the completed durationThis keeps the visible tutorial behavior while moving state updates out of
$effect.Additional Information
Validation:
SHARP_IGNORE_GLOBAL_LIBVIPS=1 mise exec node@24.15.0 -- pnpm install --frozen-lockfilemise exec node@24.15.0 -- pnpm prettier --write apps/svelte.dev/content/tutorial/04-advanced-sveltekit/03-link-options/01-preload/+assets/app-a/src/routes/+layout.svelte apps/svelte.dev/content/tutorial/04-advanced-sveltekit/03-link-options/01-preload/+assets/app-b/src/routes/+layout.sveltemise exec node@24.15.0 -- pnpm -r packagemise exec node@24.15.0 -- pnpm --filter svelte.dev lintmise exec node@24.15.0 -- pnpm --filter svelte.dev checkgit diff --checkCurrent GitHub check note: the only red status is Vercel authorization for the Svelte team account, not a test failure.