Expand WorkerCommandLineFactory tests for the worker command string#10
Merged
Conversation
Cover option mirroring (bool flags, null skip, memory-limit assign form, escaped string values), excluded framework globals, multiple paths, and the project config file position right after the worker command name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9. Locks down the exact worker command string built by
WorkerCommandLineFactory::create().Added cases
true→--flag,false→ omittednulloption → omittedmemory-limit→ assign form--memory-limit=-1--name 'value'no-interaction,verbose,ansi,help,output-format) → omitted--config 'ecs.php'right after theworkercommand nameVerified
phpunit— 10 tests greenphpstan— no errors