feat: send flow design updates v60#863
Open
jvsena42 wants to merge 21 commits intofeat/settings-v60from
Open
Conversation
… speed -> settings default (if custom) -> slow fee rate -> 1
Member
Author
|
Testing ... |
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendConfirmScreen.kt
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendConfirmScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendConfirmScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendConfirmScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/to/bitkit/ui/screens/wallets/send/SendConfirmScreen.kt
Outdated
Show resolved
Hide resolved
| it.copy( | ||
| payMethod = SendMethod.LIGHTNING, | ||
| fee = SendFee.Lightning(0), | ||
| isAmountInputValid = validateAmount(it.amount, SendMethod.LIGHTNING), |
There was a problem hiding this comment.
Code review
switchToLightning() does not clear confirmedWarnings, while onPaymentMethodSwitch() does (line 1123). This inconsistency means a user who confirmed a sanity warning on the on-chain path and then taps "Instant" on the fee screen will carry stale confirmedWarnings into the Lightning path, bypassing the check on next send attempt.
Suggested change
| isAmountInputValid = validateAmount(it.amount, SendMethod.LIGHTNING), | |
| payMethod = SendMethod.LIGHTNING, | |
| fee = SendFee.Lightning(0), | |
| isAmountInputValid = validateAmount(it.amount, SendMethod.LIGHTNING), | |
| confirmedWarnings = persistentListOf(), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements v60 design for the send flow, matching iOS PR #488.
Description
This PR:
SendSectionViewcomponentSwipeToConfirmfor driving animationsPreview
QA Notes
1. Show/Hide Details Toggle
On-chain payment:
Lightning payment:
LNURL Pay:
2. Send From / Payment Method Switch
Unified invoice (BIP21) - Confirm screen:
Unified invoice - Button disabled when conditions not met:
Non-unified invoice - Confirm screen:
Amount screen switching:
3. Fee Rate Screen - Instant Option
Unified payment:
Non-unified payment:
4. Custom Fee Defaults
5. Relative Invoice Expiry
6. Layout & Spacing
7. Regression