Open
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
app/src/main/java/to/bitkit/ui/components/ConnectionIssuesView.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Member
Author
|
@piotr-iohk I suppose there is a missing update in a test flow, because of the detail button |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #873
Description
This PR adds a reusable connection issues overlay view and improves network recovery behavior across multiple flows.
Connection Issues Overlay
ConnectionIssuesViewcomposable with phone illustration, dashed gradient rings, and a loading spinnerAnimatedVisibilityNetwork Recovery Improvements
LightningRepo.canSend()fallback: When channels are loading (nodeStartingor channels not yet usable after reconnect), falls back to cachedtotalLightningSatsbalance instead of returningfalse— fixes unified invoices only showing savings option after reconnectingSpendingAmountScreenrefresh: Re-triggersupdateLimits()when connectivity state changes, so the "Available" field updates after coming back onlineIsOnlineTrackerfix: FixedisFirstEmissionflag never being set tofalse, which prevented connectivity toasts from ever appearingLightningRepo.awaitPeerConnected(): New method that polls for peer reconnection (up to 30s) before attempting cooperative channel close — prevents "Cannot begin shutdown while peer is disconnected" errors during transfer to savings after internet toggleTransferViewModel.closeChannels(): CallsawaitPeerConnected()before attempting cooperative close, reducing unnecessary INTERRUPTED state in the savings progress screenPreview
transfer-to-spending.webm
receive-sheet.webm
send-sheet.webm
transfer-to-savings.webm
QA Notes
Connection Issues Overlay
Network Recovery — Send Flow
Network Recovery — Transfer to Savings
Connectivity Toasts