ci: add release workflows#959
Open
ovitrif wants to merge 11 commits into
Open
Conversation
ben-kaufman
reviewed
May 22, 2026
| output_dir=${OUTPUT_DIR:-.ai/reproducible-release} | ||
| bundletool_version=${BUNDLETOOL_VERSION:-1.18.1} | ||
| bundletool_sha256=${BUNDLETOOL_SHA256:-a73341a7945abcb0e6b8971c7b1b2801bd765006447ca0d2437a4260d572ceac} | ||
| bundletool_url=${BUNDLETOOL_URL:-https://repo1.maven.org/maven2/com/android/tools/build/bundletool/${bundletool_version}/bundletool-${bundletool_version}.jar} |
Contributor
There was a problem hiding this comment.
The default bundletool_url points at Maven Central, but this artifact returns 404 there:
https://repo1.maven.org/maven2/com/android/tools/build/bundletool/1.18.1/bundletool-1.18.1.jar
A fresh run without BUNDLETOOL_JAR fails in download_bundletool before creating the APK set. Could we switch it to the Google Maven URL instead?
https://dl.google.com/dl/android/maven2/com/android/tools/build/bundletool/1.18.1/bundletool-1.18.1.jar
ben-kaufman
reviewed
May 22, 2026
| Debug builds include placeholder Firebase configuration so a fresh clone can compile without private `google-services.json` files. | ||
|
|
||
| Download `google-services.json` from the Firebase Console when you need real Firebase integration for push notifications testing: | ||
| - devDebug: Place in `app/src/devDebug/google-services.json` |
Contributor
There was a problem hiding this comment.
These debug Firebase paths are tracked placeholder files, so replacing them with real configs makes Git show secret-bearing changes. Could we document a safe local workflow, or adjust the config strategy so real Firebase files stay ignored?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #953
Supersedes: #867 (closed as outdated in favor of #953)
This PR:
Description
The core change is adding
releaseandrelease-internalGitHub Actions workflows. Both workflows build signed mainnet release artifacts from protected environment secrets.releasekeeps both APK and AAB outputs for Play/GitHub release handling, whilerelease-internalproduces the mainnet APK signed with the internal keystore.The reproducibility support adds a
Reproducible Releaseworkflow andscripts/reproduce-release.shto buildbundleMainnetRelease, recreate APK splits with bundletool, extractarm64-v8anative libraries, and upload checksum evidence. The new documentation explains how this relates to WalletScrutiny issue #953 and captures the currently known native library mappings.GitHub Actions setup:
releaseandrelease-internalGitHub environments for the protected release workflows.releaseenvironment secrets:MAINNET_RELEASE_GOOGLE_SERVICES_JSON_BASE64,BITKIT_KEYSTORE_BASE64,BITKIT_KEYSTORE_PASSWORD,BITKIT_KEY_ALIAS, andBITKIT_KEY_PASSWORD.release-internalenvironment secrets:MAINNET_RELEASE_GOOGLE_SERVICES_JSON_BASE64,INTERNAL_KEYSTORE_BASE64,INTERNAL_KEYSTORE_PASSWORD,INTERNAL_KEY_ALIAS, andINTERNAL_KEY_PASSWORD.These will be added AFTER the PR is approved.
Remaining upstream work for #953:
bitkit-core-android/ Rust-native AAR builds reproducible upstream.Cargo.lock, build paths,SOURCE_DATE_EPOCH, path remapping, stripping, and published native.sochecksums.androidx.datastore:datastore-coreandnet.java.dev.jna:jnawith diffoscope evidence.Preview
N/A
QA Notes
Manual Tests
N/A
Automated Checks
bash -n scripts/reproduce-release.sh.github/workflows/release.yml,.github/workflows/release-internal.yml, and.github/workflows/reproducible-release.ymlgo run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/reproducible-release.yml .github/workflows/release.yml .github/workflows/release-internal.yml