chore: add just launcher commands#962
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47bb0634af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1c0320df4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ovitrif
changed the title
| @@ -0,0 +1,18 @@ | |||
| # Copy to .env and fill only what you need. | |||
|
|
|||
| GITHUB_ACTOR= | |||
There was a problem hiding this comment.
After just init, .env contains empty GITHUB_ACTOR and GITHUB_TOKEN values. Since just loads .env for every Gradle recipe, those empty env vars win over gpr.user and gpr.key from local properties. Could we either comment out the optional credential keys in .env.example, or make getGithubCredentials() ignore blank env values?
| KEY_ALIAS= | ||
| KEY_PASSWORD= | ||
|
|
||
| E2E=false |
There was a problem hiding this comment.
E2E and GEO come from the auto-loaded .env, so they also affect just build and just release. A local .env used for E2E can accidentally produce a normal or release build with BuildConfig.E2E=true or GEO=false. Could we keep these build-mode flags out of the auto-loaded template, or explicitly set safe defaults in non-E2E recipes?
| - macOS: `brew install just` | ||
| - Linux: `mkdir -p ~/.local/bin && curl --proto '=https' --tlsv1.2 -sSf https://just.systems/install.sh | bash -s -- --to ~/.local/bin` | ||
| - Windows: `winget install --id Casey.Just --exact` | ||
| - Windows shell: install Git for Windows or another `sh` provider for Bash-backed recipes. |
There was a problem hiding this comment.
This says another sh provider is enough on Windows, but just init runs through #!/usr/bin/env bash and uses Bash syntax like [[ ... ]] and pipefail. Could we either say Windows needs a Bash provider, like Git for Windows, or make init POSIX-sh compatible?
3 participants
This PR adds a Just command launcher for common local Android development tasks.
Description
This PR:
.env.exampletemplate andjust initfor creating the ignored local.envfile.Preview
N/A
QA Notes
Manual Tests
N/A
Automated Checks
just initjust listjust --dry-run releasejust --dry-run test file LightningRepoTestjust --dry-run test lane ComposeUijust --dry-run translations pulljust --dry-run e2e network assembleTnetReleasejust --dry-run e2e no geojust compilejust testjust lintjust buildjust --unstable --fmt --check