Skip to content

feat: trezor hardware support#507

Merged
ovitrif merged 10 commits into
masterfrom
feat/trezor-integration
May 21, 2026
Merged

feat: trezor hardware support#507
ovitrif merged 10 commits into
masterfrom
feat/trezor-integration

Conversation

@coreyphillips
Copy link
Copy Markdown
Contributor

Description

The intention of this Trezor dev dashboard is to serve as a place for developers to test and troubleshoot Trezor hardware features as they emerge. This is not meant to be user facing, but to serve as a reference for how to use and interact with Trezor hardware devices once work on user-facing Trezor features begin by the mobile team.

  • Implements Trezor hardware support via bluetooth
  • Implements a Trezor dev dashboard that is only be accessible in dev mode at the following location:
    Settings->Advanced->Trezor
  • Supports address generation, public key export, message signing, balance lookup, transaction creation, signing & broadcast

Introduce BLE-based Trezor support including device discovery, connection management, PIN/passphrase/pairing flows, address generation, message signing, transaction creation/signing, and  balance lookup. Gated behind dev settings.
@coreyphillips coreyphillips self-assigned this Mar 25, 2026
@coreyphillips coreyphillips added the enhancement New feature or request label Mar 25, 2026
Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Reviewed for bugs and CLAUDE.md compliance. Found 3 issues: 1 confirmed bug and 2 CLAUDE.md violations.

Comment thread Bitkit/Views/Trezor/TrezorRootView.swift
Comment thread Bitkit/Services/Trezor/TrezorBLEManager.swift
Comment thread Bitkit/Views/Trezor/TrezorAddressView.swift
@ovitrif ovitrif added this to the 2.3.0 milestone Apr 7, 2026
@ovitrif ovitrif self-assigned this Apr 7, 2026
ovitrif and others added 5 commits May 1, 2026 17:43
# Conflicts:
#	Bitkit.xcodeproj/project.pbxproj
#	Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	Bitkit/AppScene.swift
#	Bitkit/Info.plist
#	Bitkit/MainNavView.swift
#	Bitkit/Views/Settings/Advanced/AdvancedSettingsView.swift
# Conflicts:
#	Bitkit.xcodeproj/project.pbxproj
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌🏻

Tests:

  • Validated the Trezor dev settings dashboard flows end-to-end.
  • Tested device discovery, connect, connected-device info, disconnect, reconnect, forget device, and credential reset.
  • Tested recoverable unavailable-device/error state.
  • Tested network selection.
  • Tested address generation for Legacy, Nested SegWit, Native SegWit, and Taproot addresses, including QR rendering.
  • Tested public key and xpub export.
  • Tested message signing, valid signature verification, and tampered-message failure.
  • Tested balance lookup by address, balance lookup by xpub, and UTXO/account result display.
  • Tested transaction history lookup and transaction detail lookup.
  • Tested compose, sign, broadcast, and txid result for an on-chain transaction.
  • Tested PIN, passphrase, pairing-code prompt surfaces, cancel paths, and confirm-on-device overlay.
  • Tested debug log behavior and redaction checks for mnemonic/passphrase leakage.

I've setup a Trezor emulator bridge and an automated testing suite to run the same validation flow in:

@ovitrif ovitrif merged commit c930d2d into master May 21, 2026
11 checks passed
@ovitrif ovitrif deleted the feat/trezor-integration branch May 21, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants